-
Notifications
You must be signed in to change notification settings - Fork 63
Feature: shmem init error checking #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…it_error_checking
…it_error_checking
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
=======================================
Coverage 77.46% 77.47%
=======================================
Files 112 112
Lines 19084 19088 +4
=======================================
+ Hits 14784 14788 +4
Misses 4300 4300 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…it_error_checking
…' into feature-shmem_init_error_checking
…g' into feature-shmem_init_error_checking
…it_error_checking
|
Thanks for the review. I argue for keeping the >0 condition everywhere since it will catch more error cases. There was one comment by @sandro-elsweijer which i believe i have answered positively. |
Closes #2102
Describe your changes here:
Related to #1985
The shared memory was often not initialized properly but we did not detect it.
I added an error code to
t8_shmem_initfollowing the convention ofsc_shmem_init.This actually caused many of our tests to fail giving more reason to this feature.
The errors are fixed with #1996 which should be merged first.
When the error code is met, we currently abort the program.
The reasoning is that shared memory should always be available to us, since it is part of MPI >=3.0
(This creates the new issue of requiring MPI 3.0 in our build system).
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).